Fix #2237: Insufficient contrast on hover state for links in tables in dark mode #2249
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaptakS
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Thanks for the PR. I see that you have changed the color for prefers-color-scheme and the hover color in data-theme=dark. Both the changes need to be applied in both the places, so that all dark mode scenarios are covered. I have left inline comments for the same. Once that is fixed, I think we can merge this PR.
calebjubal
commented
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the issue where table links in dark mode were not clearly visible when hovered. The color contrast was too low, making the text hard to read.
Changes Made
Added a new SCSS variable for dark mode:
Updated the link hover color in dark mode tables:
And changed the default color of the table links in light mode for contrast:
Replaced static color references with theme variables where applicable for consistency.
Screenshots
Dark Mode:
Light Mode:
Testing
Verified in both light and dark themes.
Confirmed that hover color works as expected in dark mode.
Checked that no other UI components or color variables were affected.